Added mtypes CLI for generating realistic avalanche metric type distributions. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
mtypes
branch
3 times, most recently
from
17c6214 to
40b524d
Compare
…ibutions. Initially added in bwplotka/prombenchy#12, but it might belong here more. Signed-off-by: bwplotka <[email protected]>
jmichalek132
reviewed
Oct 9, 2024
jmichalek132
reviewed
Oct 9, 2024
bwplotka
added a commit
that referenced
this pull request
Oct 9, 2024
See related discussion: #97 (comment) > I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often? cc @jmichalek132 Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka
added a commit
that referenced
this pull request
Oct 9, 2024
See related discussion: #97 (comment) > I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often? cc @jmichalek132 Signed-off-by: Bartlomiej Plotka <[email protected]>
prateeknayak
pushed a commit
to prateeknayak/avalanche
that referenced
this pull request
Jan 2, 2025
…ibutions. (prometheus-community#97) Initially added in bwplotka/prombenchy#12, but it might belong here more.
prateeknayak
pushed a commit
to prateeknayak/avalanche
that referenced
this pull request
Jan 2, 2025
…heus-community#99) See related discussion: prometheus-community#97 (comment) > I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often? cc @jmichalek132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially added (and carefully reviewed by @ridwanmsharif) in bwplotka/prombenchy#12, but it might belong here much more.
See mtypes Readme in the diff to learn why it's useful.
cc @jmichalek132 @ridwanmsharif